Update Graphics.js #198
Merged
Update Graphics.js #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
■不具合の内容 ローディングバーが画面外に表示されることがある。 ■再現手順 1. MV バージョン 1.6.1 の新規プロジェクトを作成する。 2. 作成した新規プロジェクトに community-1.3 を適用する。 3. テストプレイを開始する。 4. ニューゲームを選択する。 5. F4 キーを押す（全画面表示する）。 6. X キーを押す（メニューを開く）。 7. X キーを押す（メニューを閉じる）。 8. F4 キーを押す（全画面表示を解除する）。※不具合発生 9. 画面の範囲外が表示されています。縦スクロールバーと横スクロールバーが表示されます。 ローディングバーが一度も表示されなくても再現します。 ■原因 Graphics._progressElement (id:loading-progress) が拡大されたまま元に戻らないため。 ■修正方法 ローディングバーは画面に合わせて拡大縮小するものと仮定して、 Graphics._updateAllElements 内に this._updateProgress() を追加します。 拡大縮小する予定がないなら別の修正になります。 拡大する処理は通っていますので多分拡大縮小するものだろうと予想して修正しました。 ご検討ください。
krmbn0576
approved these changes
Jan 5, 2019
Collaborator
krmbn0576
left a comment
krmbn0576
left a comment
There was a problem hiding this comment.
LGTM 😇
Thank you for complete and easy-to-understand explanation.
It was very helpful!
Contributor
Author
|
Thank you for your review! (Probably, I don't have merge permission.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
** Content of trouble
The loading bar may be displayed outside the screen.
** Reproduction procedure
This phenomenon occurs regardless of whether the loading bar is hidden or displayed.
** Cause
This is because the size of Graphics._progressElement (element id: 'loading-progress') is not changed to its original size.
** How to fix
Assuming that the loading bar is scaled to fit the screen,
Add this._updateProgress() in Graphics._updateAllElements
If there is no intention to scale it will be another solution.
Since we are going through the enlarging process, we corrected it by assuming that it would likely be scaled up.
Please consider.